fix: update architecture diagrams #241
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
davenportjw
commented
Jul 31, 2023
davenportjw
commented
- updates architecture diagrams for Workflows and removes Functions
|
/gcbrun |
g-awmalik
approved these changes
Sep 11, 2023
build/int.cloudbuild.yaml
Outdated
| @@ -39,6 +39,9 @@ steps: | |||
| - id: apply-dwh | |||
| name: 'gcr.io/cloud-foundation-cicd/$_DOCKER_IMAGE_DEVELOPER_TOOLS:$_DOCKER_TAG_VERSION_DEVELOPER_TOOLS' | |||
| args: ['/bin/bash', '-c', 'cft test run TestDataWarehouse --stage apply --verbose'] | |||
| - id: wait-for-post-apply-steps | |||
| name: 'gcr.io/cloud-foundation-cicd/$_DOCKER_IMAGE_DEVELOPER_TOOLS:$_DOCKER_TAG_VERSION_DEVELOPER_TOOLS' | |||
| args: ['sleep', '$_API_ACTIVATION_SECONDS_WAIT'] | |||
There was a problem hiding this comment.
nit: do you want to just pass the arg for the no. of seconds here directly instead of using a variable? Also, _API_ACTIVATION_SECONDS_WAIT isn't really accurate.
There was a problem hiding this comment.
If this wait is needed during local test execution too, doing it within verify func with time.sleep() is better.
There was a problem hiding this comment.
local tests in this still assume running all of the apply stages prior correct?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.